-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oracle: Lightweight Connection Validation #1451
Conversation
Hi @loiclefevre , I would appreciate your advice on this. Is the cc @DavideD |
Hey @tsegismont, @loiclefevre is on his well-deserved holiday, hence I'm adding @jeandelavarene to this thread to provide guidance on your question about Meanwhile, according to the JavaDoc it would seems indeed that |
Here is a description of the different validation modes in decreasing order of validation strength:
Note that, for example, a "SOCKET" validation may return a false positive (it may not always detect all socket defects). On the other hand, a "SOCKET" validation is much faster than "NETWORK". In most cases, we recommend using "SOCKET" validation at connection borrow (in UCP for example). For applications that can't tolerate an error on the connection, turning on "SERVER" or "NETWORK" would be more appropriate. CC @gvenzl |
See eclipse-vertx#1450 Signed-off-by: Thomas Segismont <[email protected]>
Thank you @gvenzl and @jeandelavarene In this part of our code we can't tolerate the driver to block (event not every time). And for the other clients (Pg, MySQL, ...etc) where Vert.x manages the connection, we only check the connection's lifecycle (variable check): vertx-sql-client/vertx-sql-client/src/main/java/io/vertx/sqlclient/impl/SocketConnectionBase.java Line 160 in ccc784a
So I think the appropriate setting is |
This setting does not make the driver block and is implemented as a simple lifecycle check. This is exactly what we do with other clients (Pg, MySQL, ...etc). Signed-off-by: Thomas Segismont <[email protected]>
* Oracle: Lightweight Connection Validation See #1450 Signed-off-by: Thomas Segismont <[email protected]> * Use NONE Connection validation. This setting does not make the driver block and is implemented as a simple lifecycle check. This is exactly what we do with other clients (Pg, MySQL, ...etc). Signed-off-by: Thomas Segismont <[email protected]> --------- Signed-off-by: Thomas Segismont <[email protected]>
See #1450