Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented LazyIterable default toImmutable[List/Set/Bag] and unit tests #1657

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

fermendivilt
Copy link
Contributor

@fermendivilt fermendivilt commented Aug 2, 2024

Fixes #1587

The tests pass; if the implementation is not what was expected (or anything else) please let me know and I'll work on it :)

Had some problems along the way, mainly because of biz.aQute.bnd.annotation.spi, when I tried to run all the tests. I still don't understand my issue (maybe the fact that I am using IntelliJ and its JDK version manager?), but the solution was to add it to a module-info.java file.

@fermendivilt fermendivilt changed the title Fixes #1587 Implemented LazyIterable default toImmutable[List/Set/Bag] and unit tests Aug 2, 2024
@fermendivilt
Copy link
Contributor Author

Uuuuhm I might require some help for this, I don't understand the error :s

@pzygielo
Copy link

pzygielo commented Aug 3, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Perf Issue: toImmutable[List/Set/Bag] methods should be overridden on LazyIterable
2 participants