Replace hand-crafted debuggers with LSP4E-based debuggers #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to how LSP4E works, we cannot use the old approach in the EML launch configurations where we run the ECL delegate then the EML delegate: this confuses LSP4E while debugging, as it considers that the debuggee for this launch has completed. Instead, we use a new EclEmlModule that acts as an orchestration layer, running the ECL module and then the EML module, in a similar way to how EgxModule orchestrates multiple modules.
We still need the EolBreakpoint classes, so users can toggle breakpoints from the Epsilon code editors. We can delete the part dedicated to exposing the state of the Epsilon modules.
|
This is currently waiting for the CI results from Jenkins. |
We need at least version 0.23.0 in order to be able to specify the reason why a breakpoint was verified or not. Version 0.23.1 is the one in our target platform and the most recent stable version, so we should require that.
agarciadom
changed the title
|
I had to make some tweaks to get the tests passing from CI and from our |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses #103. It is a full replacement of the old debuggers we had with LSP4E-based ones, using our new remote debugging codebase. This ensures that the experience will be consistent across local and remote debugging, and benefits from some things the new DAP-based debuggers can do (e.g. debugging the EGL templates launched by an EGX script).