Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix recursion error on OnigRegExp with unicode chars #144

Closed
wants to merge 1 commit into from

Conversation

fabioz
Copy link
Contributor

@fabioz fabioz commented Sep 15, 2017

@angelozerr
Copy link
Contributor

angelozerr commented Sep 16, 2017

@fabioz thanks for your PR. AT first I think you must sign the PR to avoid having problem with IP validation.

I tell me if a better fix could be handle by #134 (comment) like node-onigurama does? But perhaps it's an another issue?

@fabioz
Copy link
Contributor Author

fabioz commented Sep 16, 2017

@angelozerr I ended up creating a new pull request (#145) as I had done this one editing through the github interface, so, properly created a branch on my fork to fix it with proper user/email/signature.

Related to the issue you posted, it's a separate issue... the error I had was that it wasn't even able to load a grammar because it had a unicode quote (https://github.com/textmate/cmake.tmbundle/blob/master/Syntaxes/CMake%20Listfile.tmLanguage#L66), not on interpreting the grammar later on.

@fabioz fabioz closed this Sep 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants