performance(calendar): Prevent unnecessary update on day component #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calendars where taking too long to update after a day is pressed, this was due unnecessary re-renders on the day component.
The re-renders are triggered due to comparing the
onPress
functions as well astheme
.Comparing the
onPress
function will alway return false if theonPress
function usesuseCallback
or any similar hook that will update the fuction as it changes it's address in the memory therefore triggering a re-render.However, comparing
onPress
oronLongPress
is crucial for theExpandableCalendar
component as it'sonPress
function has multiple jobs like closing the calendar on day select if it was true. If we stopped comparing theonPress
oronLongPress
functions theExpandableCalendar
closeOnDayPress
won't work as expected.TODO:
closeOnDayPress
work without having to re-render all of the day components.