Skip to content

Commit

Permalink
always return data reference in a list
Browse files Browse the repository at this point in the history
  • Loading branch information
cocoa-xu committed Jun 23, 2024
1 parent 10f74c8 commit e225123
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
3 changes: 2 additions & 1 deletion c_src/adbc_column.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,8 @@ ERL_NIF_TERM make_adbc_column(ErlNifEnv *env, struct ArrowSchema * schema, ERL_N

if (data_ref) {
keys.emplace_back(kAtomDataKey);
values.emplace_back(data_ref.value());
ERL_NIF_TERM data_ref_list = enif_make_list1(env, data_ref.value());
values.emplace_back(data_ref_list);
}

ERL_NIF_TERM adbc_column;
Expand Down
5 changes: 1 addition & 4 deletions lib/adbc_connection.ex
Original file line number Diff line number Diff line change
Expand Up @@ -410,10 +410,7 @@ defmodule Adbc.Connection do
defp merge_columns(chucked_results) do
Enum.zip_with(chucked_results, fn columns ->
Enum.reduce(columns, fn column, merged_column ->
merged_data =
List.wrap(merged_column.data) ++ List.wrap(column.data)

%{merged_column | data: merged_data}
%{merged_column | data: merged_column.data ++ column.data}
end)
end)
end
Expand Down

0 comments on commit e225123

Please sign in to comment.