WiFiSTA - method setDNS as in WiFi libraries by Arduino #9021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-a-v
reviewed
Nov 8, 2023
JAndrassy
force-pushed
the
wifi_setdns
branch
from
d44a5bb
to
b103237
Compare
d-a-v
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arduino doc: https://www.arduino.cc/reference/en/libraries/wifi/wifi.setdns/
I compared more than a dozen of Arduino Networking libraries to find the common API for Arduino networking. Then I wrote a test sketch which checks how a library complies to this common API.
ESP8266 Arduino WiFi library was based on the first WiFi library by Arduino. Then ESP32 Arduino WiFi library was based on ESP8266 Arduino WiFi library. Arduino then created more WiFi libraries and the API diverged, but at least with the most recent library they looked at the ESP32 WiFi library for new method names (for example dnsIP(n)).
While doing the research and tests I do PR in Arduino networking libraries repositories with in most cases simple modifications to unify the API where it doesn't break the library (for example I will not ask esp8266 and esp32 maintainers to make WiFi.begin blocking :-) ).