LwipIntfDev - method end() to enable repeated begin #9023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAndrassy
force-pushed
the
intfdev_end_rebegin
branch
from
8587f46
to
bb62337
Compare
d-a-v
reviewed
Nov 10, 2023
JAndrassy
force-pushed
the
intfdev_end_rebegin
branch
2 times, most recently
from
757dda7
to
b9dc628
Compare
d-a-v
reviewed
Nov 10, 2023
JAndrassy
force-pushed
the
intfdev_end_rebegin
branch
from
b9dc628
to
55d5efe
Compare
d-a-v
reviewed
Nov 12, 2023
JAndrassy
force-pushed
the
intfdev_end_rebegin
branch
from
55d5efe
to
ee21635
Compare
JAndrassy
force-pushed
the
intfdev_end_rebegin
branch
from
ee21635
to
3594be9
Compare
d-a-v
approved these changes
Nov 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While it is not a common use, I think it should be possible to do Ethernet.end() and then Ethernet.begin() with a different static IP or return to DHCP after using a static IP.
I tested it with LegacyEthernetTest with hardwareStatus and linkStatus commented out (they don't work before begin here) and with hostByName commented out and with the getters/setters PR.