Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upload.py - exception handling fixes #9186

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Commits on Dec 7, 2023

  1. upload.py - more exception handling fixes

    - don't check exc_info() in `finally`, it only works without `except` with just `try` and `finally`
      see https://docs.python.org/3/reference/compound_stmts.html#try
      after `except Exception as e:` block, `e` is already deleted
    
    - handle a rare case when esptool code does not close 'erase_file'.
      printing paths may cause encoding issues, so just fall through silently
    mcspr committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    b799a3c View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2024

  1. wrap remove exc too

    mcspr committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    2ef9809 View commit details
    Browse the repository at this point in the history
  2. revert fatal os.remove

    mcspr committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    4268947 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    92c1e32 View commit details
    Browse the repository at this point in the history