Add Peblar

[PieVo]

Hey EVCC team,

Here is a charger implementation for the Peblar chargers (https://peblar.com/products/ev-charging). Developer info on the modbus API is located at developer.peblar.com.

I've been using this implementation for a while and tested it for the 1p3p switchover to work. This switchover won't work on all variants due to relay configurations (and 1 phase connected systems ofc).

I've checked the doc build to run fine and cleaned out some lint errors. Can you review this code?

[andig]

This should return the switched phases- 1 or 3. If config is fixed to 1p connected switching will never be invoked. Why do we need this complexity here?

[PieVo]

Clear..
2 relays, 3phase connected: Both GetPhases & phase1p3p supported.
1 or 2 relays, 1phase connected: No GetPhases, no phase1p3p.

But what about the option where we switch all phases with 1 relay? Clearly no phase1p3p, but also no GetPhases?

[andig]

But what about the option where we switch all phases with 1 relay? Clearly no phase1p3p, but also no GetPhases?

Not quite sure what you mean. If box is connected 1p that's part of loadpoint config that we rely on. GetPhases will only every be called if Phases1p3p is actually available.

[andig]

GetPhases should be decorated together with phases1p3p.

[PieVo]

Ok.. I was under the assumption that GetPhases is always useful for EVCC to known how many phases are attached and usable. Let's say a 3-phase box which is connected with just 1 phase: it does not need GetPhases?

[andig]

See above- not used.

[PieVo]

Hmm, something bad happens to the currents, I'm getting a lot of these:

"Garage: charger logic error: current mismatch (got 15.1A measured, expected 12.2A)"

Need to find out if it is related to the recent changes.

[andig]

There is a 1A difference between set current and max phase current observed:

		// use measured phase currents as fallback if charger does not provide max current or does not currently relay from vehicle (TWC3)
		if !isCg || errors.Is(err, api.ErrNotAvailable) {
			// validate if current too high by more than 1A (https://github.com/evcc-io/evcc/issues/14731)
			if current := lp.GetMaxPhaseCurrent(); current > lp.chargeCurrent+1.0 {
				if shouldBeConsistent {
					lp.log.WARN.Printf("charger logic error: current mismatch (got %.3gA measured, expected %.3gA)", current, lp.chargeCurrent)
				}
				lp.chargeCurrent = current
				lp.bus.Publish(evChargeCurrent, lp.chargeCurrent)
			}
		}