Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add relevant links in the footer #170

Open
gridhead opened this issue Sep 29, 2021 · 21 comments · May be fixed by #698
Open

Add relevant links in the footer #170

gridhead opened this issue Sep 29, 2021 · 21 comments · May be fixed by #698
Labels
fragment A functional rewrite of the project frontend Frontend development good first issue Good for newcomers hacktoberfest Contribute here to get a free tee T: new change Adds new capabilities or functionality

Comments

@gridhead
Copy link
Member

Like the one at https://getfedora.org/.

Screenshot from 2021-08-30 21-04-08

@gridhead gridhead added good first issue Good for newcomers T: new change Adds new capabilities or functionality fragment A functional rewrite of the project frontend Frontend development labels Sep 29, 2021
@siddhantkhariwal
Copy link

Hey, Can I fix this issue?

@gridhead
Copy link
Member Author

Sure, please go ahead.

@gridhead
Copy link
Member Author

@siddhantkhariwal, could you please provide an ETA for this?

@siddhantkhariwal
Copy link

Will complete in 24hrs.

@gridhead
Copy link
Member Author

Sounds good. Please derive a new branch from the fragment branch https://github.com/fedora-infra/mote/tree/fragment and be sure to target your PR against it.

@siddhantkhariwal
Copy link

Sounds good. Please derive a new branch from the fragment branch https://github.com/fedora-infra/mote/tree/fragment and be sure to target your PR against it.

When I am opening this link it is showing an error 404 page.

@gridhead
Copy link
Member Author

We moved that branch to become the primary branch for the repository. Now, you can derive from the main branch and target the main branch in your PR.

@siddhantkhariwal
Copy link

We moved that branch to become the primary branch for the repository. Now, you can derive from the main branch and target the main branch in your PR.

Okay, Thank you.

@gridhead gridhead added the hacktoberfest Contribute here to get a free tee label Sep 30, 2021
@siddhantkhariwal
Copy link

We moved that branch to become the primary branch for the repository. Now, you can derive from the main branch and target the main branch in your PR.

Hello @t0xic0der . I have made the footer with all the relevant links but I am having trouble with the Facebook and Twitter icons. It is showing a blank square instead of the original icon. I searched on stack overflow but was still not able to get the icons. Other than that the footer is complete.

@siddhantkhariwal
Copy link

Hey @t0xic0der can you help me with this?

We moved that branch to become the primary branch for the repository. Now, you can derive from the main branch and target the main branch in your PR.

Hello @t0xic0der . I have made the footer with all the relevant links but I am having trouble with the Facebook and Twitter icons. It is showing a blank square instead of the original icon. I searched on stack overflow but was still not able to get the icons. Other than that the footer is complete.

@gridhead
Copy link
Member Author

gridhead commented Oct 3, 2021

Sure. Can you check if you can obtain the icons from FontAwesome?

@siddhantkhariwal
Copy link

Sure. Can you check if you can obtain the icons from FontAwesome?

Yes, I tried with font awesome icons but it is showing only blank squares, I am unable to solve that issue.

@gridhead
Copy link
Member Author

gridhead commented Oct 4, 2021

@siddhantkhariwal,

Could you make it happen without those icons? We can always add those icons in a subsequent PR.

@siddhantkhariwal
Copy link

@siddhantkhariwal,

Could you make it happen without those icons? We can always add those icons in a subsequent PR.

Yeah, okay I'll just create a pr.

@siddhantkhariwal
Copy link

Hey, @t0xic0der I created a pr, kindly check through it and let me know for any feedback.

@khansaUmatullah
Copy link

@t0xic0der no one is working on this issue is it about to close?
Can I work on this?

@subhangi2731
Copy link
Contributor

@t0xic0der @darknao I want to work on this issue. please assign me this one

@yashbajoria05
Copy link

Please this issue to me

@RuthM-K
Copy link

RuthM-K commented Mar 12, 2024

Hello @gridhead, Can I work on this issue as well?

@RuthM-K
Copy link

RuthM-K commented Mar 12, 2024

Hello @gridhead I'm also an Outreachy applicant; Can i be assigned this issue please?

@gridhead gridhead linked a pull request Mar 13, 2024 that will close this issue
@gridhead
Copy link
Member Author

We already have a pending pull request on this issue ticket #698.

Please feel free to collaborate with the author of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fragment A functional rewrite of the project frontend Frontend development good first issue Good for newcomers hacktoberfest Contribute here to get a free tee T: new change Adds new capabilities or functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants