-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added footer in 404 page #212
Conversation
Mmhh.. I'm not sure, something looks off with the footer taking the full width, and not being completely at the bottom when using a large enough window. |
@darknao Can you share a screenshot of the footer being off the bottom? In my case, the 404 page footer is still at the very bottom of the page in all window sizes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same for me, I guess.
@subhangi2731, could you check if there's an inbuilt footer component packed in Bootstrap 5?
56ecb7a
to
137906d
Compare
@darknao I have updated the changes please review |
@t0xic0der @darknao please review my updated PR |
This is still not working. But there is several way to solve this issue. |
@darknao okay I will do this and update the PR |
137906d
to
503e55a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@t0xic0der sorry will correct the padding other than this is everything okay? |
@subhangi2731, I'd suggest that you correct the padding first and then maybe, I'll give it another round of review to see if there's anything else that needs changing. |
@t0xic0der sure I will fix this and also the card component so that the footer gets aligned downwards in its position |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please ignore #212 (review). Changes are still needed.
7f352c9
to
7798c59
Compare
@t0xic0der @darknao I corrected the long padding, kept all the contents in the card component, and then also brought the footer in correct alignment and now it's totally down touching the end of the page. Please check and let me know |
@darknao sure |
7798c59
to
b5f61bd
Compare
b5f61bd
to
c73ce5c
Compare
@darknao please check and let me know |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Signed-off-by: Akashdeep Dhar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made one small change to bring the card segment to the center of the page.
@t0xic0der great thanks |
Closes #211
Added footer in 404-error page.