Add some tests for the repository assets wrangling options #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done to ensure the best compatibility with the test cases to be included Signed-off-by: Akashdeep Dhar <[email protected]>
Rework some other elements as they are needed to be Signed-off-by: Akashdeep Dhar <[email protected]>
samyak-jn
reviewed
Oct 16, 2023
| standard.sbrcavbl = list(brcslist) | ||
| return True, brcslist | ||
| else: | ||
| return False, "Cloned source namespace assets could not be found" |
There was a problem hiding this comment.
I see we have removed the try blocks and expectations area, was there any specific reason for it? The removal of the try-except block means that any exceptions occurring within this code will propagate up to the caller without being handled.
There was a problem hiding this comment.
@samyak-jn, yes and the caller is capable of handling the exception.
Adding exception handling in both places, i.e. the caller and the driver makes less sense and makes it difficult to reproduce tests related to them.
samyak-jn
approved these changes
Oct 16, 2023
gridhead
added a commit
that referenced
this pull request
Dec 13, 2023
Add some tests for the repository assets wrangling options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge this pull request after merging #32, please
Fixes #37