Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: migrate to streamx #893

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ThaUnknown
Copy link

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix
[ ] New feature
[x] Other, please explain:

What changes did you make? (Give an overview)
Migrated to streamx
Which issue (if any) does this pull request address?
webtorrent/webtorrent#1971
Is there anything you'd like reviewers to focus on?
Tests.

Previously this forced Buffer, now it's... whatever the browser yields. This causes 2 tests to fail.

Node readable state's are different from streamx's readable states. This causes 4 tests to fail, as I likely edited the code for these changes and tests incorrectly, I'm not certain how to handle this.

@jzombie
Copy link

jzombie commented Jul 30, 2022

Out of curiosity, what is the benefit of this migration to streamx?

Edit: Disregard, I see the discussion: webtorrent/webtorrent#1971

@nosovk
Copy link

nosovk commented Aug 18, 2022

@feross any concerns about merging this?

@ThaUnknown
Copy link
Author

@feross any concerns about merging this?

yes, it's broken as streamx handles stream states differently, and I don't know how to fix it, there are like 11 other PR's in the webtorrent ecosystem before this one which are actually working

@socket-security
Copy link

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues
AI detected security risk ✅ 0 issues
AI warning ✅ 0 issues

📊 Modified Dependency Overview:

➕ Added Package Capability Access +/- Transitive Count Publisher
[email protected] None +2 mafintosh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants