loadtxt/savetxt
: do not require space after last entry
#877
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to address #862.
The current formats require an end-of-row space both in
savetxt
andloadtxt
, i.e.,This PR proposes to not require a space after the last record, i.e.,
This should hopefully improve the seldom crashing CI tests.
@fortran-lang/stdlib @chuckyvt @minhqdao
PS: these routines would benefit from some form of error control in the
read
andwrite
statements.Without changing the API, I propose checking for
iostat
andiomsg
, so that when something goes wrong, an error can be produced to give information about what happened (what file, which line).