Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings [-Wunused-xxx] from compilation #879

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix warnings [-Wunused-xxx] from compilation #879

wants to merge 1 commit into from

Conversation

cyrilgandon
Copy link

@cyrilgandon cyrilgandon commented Oct 2, 2024 •
edited
Loading

Cleaning duty, warnings are generates with

fpm build --verbose --flag '-Wunused-variable -Wunused-dummy-argument -Wunused-parameter'

Progress

  • 42 unused-variable
  • 67 unused-dummy-argument
  • 15 unused-parameter

@cyrilgandon cyrilgandon changed the title Remove warning -Wunused-variable from compilation Fix warningq -Wunused-xxx from compilation Oct 2, 2024
@cyrilgandon cyrilgandon changed the title Fix warningq -Wunused-xxx from compilation Fix warnings [-Wunused-xxx] from compilation Oct 2, 2024
@cyrilgandon cyrilgandon mentioned this pull request Oct 4, 2024
Open
perazz
perazz approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@perazz perazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @cyrilgandon.

awvwgk
awvwgk approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@awvwgk awvwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sharing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perazz perazz perazz approved these changes

@awvwgk awvwgk awvwgk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cyrilgandon @perazz @awvwgk