Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add Learn Pseudo-classes workshops #569

Merged
merged 5 commits into from
Sep 18, 2024

Conversation

larymak
Copy link
Contributor

@larymak larymak commented Sep 10, 2024

Checklist:

Closes #421

@jdwilkin4
Copy link
Contributor

I have concerns that this will be to similar to the build a personal portfolio page that they have to build.
Cane we change this to something else?

@larymak
Copy link
Contributor Author

larymak commented Sep 11, 2024

I have concerns that this will be to similar to the build a personal portfolio page that they have to build. Cane we change this to something else?

Can I replace it with a Portfolio gallery?

@jdwilkin4
Copy link
Contributor

will the portfolio gallery be different then the flexbox workshop we are adding?
https://www.freecodecamp.org/learn/2022/responsive-web-design/learn-css-flexbox-by-building-a-photo-gallery/step-24

If the projects are different enough, then that should be fine. otherwise, you will need to find another option. Remember that Tom created that sheet of project ideas. so you can look to that if you need ideas, or message the team for potential ideas 👍

@larymak
Copy link
Contributor Author

larymak commented Sep 17, 2024

will the portfolio gallery be different then the flexbox workshop we are adding? https://www.freecodecamp.org/learn/2022/responsive-web-design/learn-css-flexbox-by-building-a-photo-gallery/step-24

If the projects are different enough, then that should be fine. otherwise, you will need to find another option. Remember that Tom created that sheet of project ideas. so you can look to that if you need ideas, or message the team for potential ideas 👍

Updated with a project from the suggestion list Greeting Card project

Copy link
Contributor

@jdwilkin4 jdwilkin4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.
A few things

no1: you shouldn't use pixels for font sizes. campers will have learned about ems and rems in the previous module. So you will need to fix that in the css.

no.2: campers will not have learned about hex values yet. that is in the next module. so you can only use named colors. please update that

Copy link
Contributor

@jdwilkin4 jdwilkin4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jdwilkin4 jdwilkin4 merged commit 1915c16 into freeCodeCamp:main Sep 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: add Learn Pseudo-classes workshops to frontend cert
2 participants