-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add Learn Pseudo-classes workshops #569
chore: add Learn Pseudo-classes workshops #569
Conversation
I have concerns that this will be to similar to the build a personal portfolio page that they have to build. |
Can I replace it with a Portfolio gallery? |
will the portfolio gallery be different then the flexbox workshop we are adding? If the projects are different enough, then that should be fine. otherwise, you will need to find another option. Remember that Tom created that sheet of project ideas. so you can look to that if you need ideas, or message the team for potential ideas 👍 |
Updated with a project from the suggestion list Greeting Card project |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good.
A few things
no1: you shouldn't use pixels for font sizes. campers will have learned about ems and rems in the previous module. So you will need to fix that in the css.
no.2: campers will not have learned about hex values yet. that is in the next module. so you can only use named colors. please update that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Checklist:
Update index.md
)Closes #421