Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Phalcon version 3 and add Phalcon version 4 #1376

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

MasterEnoc
Copy link
Contributor

  • Updated the versions and releases in the scraper file
  • Ensured the license is up-to-date and that the documentation's entry in the array in about_tmpl.coffee matches it's data in self.attribution
  • Ensured the icons and the SOURCE file in public/icons/your_scraper_name/ are up-to-date if the documentation has a custom icon
  • Ensured self.links contains up-to-date urls if self.links is defined
  • Tested the changes locally to ensure:
    • The scraper still works without errors
    • The scraped documentation still looks consistent with the rest of DevDocs
    • The categorization of entries is still good

Note that version 2 was removed because its documentation pages are no longer available.

- Delete Phalcon version 2 since pages of its documentations
  are not longer available
@MasterEnoc MasterEnoc requested a review from a team as a code owner November 24, 2020 21:26
@simon04
Copy link
Contributor

simon04 commented Nov 24, 2020

Note that version 2 was removed because its documentation pages are no longer available.

If feasible, we should archive the old versions in devdocs nevertheless…

Syntax highlighting is broken: 2020-11-24-231301

@MasterEnoc
Copy link
Contributor Author

Syntax highlight added and style improved. Proceed to review

@simon04
Copy link
Contributor

simon04 commented Nov 26, 2020

The methods of a class lost their styles…

2020-11-26-230256

@MasterEnoc
Copy link
Contributor Author

This lack of style happened because of the html implemented in the page. Now phalcon docs use 'p' and 'table' tags for methods without any particular id or class, as you can see in the images I'm attaching. Style can be implemented but I have to figure out how since traversing through all the 'p' and 'table' tags would break the style.
image
image

@scherepn
Copy link
Contributor

scherepn commented Dec 3, 2020

Wow. The new phalcon documentation is truly terrible. It's perhaps the worst documentation I've seen so far.

It may actually be easier to contact the Phalcon team and work with them to improve their documentation than fix it on our end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants