Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node.js, homebrew, react-bootstrap #1992

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

AnmolDh
Copy link

@AnmolDh AnmolDh commented May 21, 2023

  • Updated the versions and releases in the scraper file
  • Ensured the license is up-to-date and that the documentation's entry in the array in about_tmpl.coffee matches its data in self.attribution
  • Ensured the icons and the SOURCE file in public/icons/your_scraper_name/ are up-to-date if the documentation has a custom icon
  • Ensured self.links contains up-to-date urls if self.links is defined
  • Tested the changes locally to ensure:
    • The scraper still works without errors
    • The scraped documentation still looks consistent with the rest of DevDocs
    • The categorization of entries is still good

@AnmolDh AnmolDh requested a review from a team as a code owner May 21, 2023 13:46
@AnmolDh AnmolDh changed the title Update node.js Update node.js, homebrew, react-bootstrap May 21, 2023
self.base_url = 'https://nodejs.org/api/'
end

version '19 LTS' do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

19 isn't an LTS release.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, since version 19 is not an LTS release and its EOL is approaching in about a week, it should not be listed, ig.

lib/docs/scrapers/react_bootstrap.rb Outdated Show resolved Hide resolved
Co-authored-by: South Drifted <[email protected]>
Copy link
Contributor

@simon04 simon04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

> bundle exec thor docs:generate --force --package react_bootstrap
ERROR:                                                                                                                                                                                                                                                          
  https://react-bootstrap.github.io/docs/layout/breakpoints/
  NoMethodError: undefined method `content' for nil:NilClass

@AnmolDh AnmolDh requested a review from simon04 July 3, 2023 08:31
@simon04
Copy link
Contributor

simon04 commented Jul 3, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants