Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker Image Refresh #2270

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

Conversation

tsengia
Copy link

@tsengia tsengia commented Jun 24, 2024

This PR combines the multiple Dockerfile's in the repo into a single, multi-stage Dockerfile that can be used to build both development and production Docker images.

I've also added a devcontainer.json file that can be used with VS Code to provider a containerized development environment. This PR was originally based off of this PR: #1337

Instead of the Docker image including all the documentation by default, now users are able to select which documentation sections they want to include in their local deployment of DevDocs.
This makes it easier/faster to publish new official Docker images of DevDocs because the image size is much smaller.
All downloaded documentation and compiled assets are stored in Docker volumes instead of being baked into the image.
This also means that new Docker images only need uploaded when code changes, and not when documentation updates.

Finally, this PR adds environment variables that can be used to configure the SSL and origin settings of DevDocs when deployed via Docker container. This helps if deploying DevDocs behind a reverse proxy/load balancer, and when running on Windows via WSL2.

This PR should close:

Once this PR is merged, I would think a new Docker image should be released again, which would close #895 and this PR.

ojeytonwilliams and others added 28 commits November 18, 2020 14:45
@tsengia tsengia requested a review from a team as a code owner June 24, 2024 01:44
@tsengia
Copy link
Author

tsengia commented Jun 26, 2024

Also, aside from this PR, I would be interested in becoming a maintainer for this repo.

…p server if docs origin and app host are the same
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update docker image
2 participants