Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Vulkan version #2283

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

morgabm
Copy link

@morgabm morgabm commented Jul 11, 2024

Hello, so I recently discovered this tool with much excitement as Khronos Docs can sometimes be cumbersome to navigate. I was disappointed to learn the Vulkan version was only 1.0. I attempted to quickly update the Vulkan scraper to the new domain and version, but upon running bundle exec thor docs:page vulkan or any other command to pull/build/generate docs I get ssl cert error:

bundle exec thor docs:page vulkan

I have verified the cert on the remote host. I also noticed an old PR suffered the same error due to changes in attribution methods. Since it has been 2 years I was wondering if something similar has changed causing these issues with the Vulkan scraper.

I attempted the same thor command above, with an unmodified version of the Vulkan scraper on the main branch, and it failed with the same error. Any suggestions?

If you're updating existing documentation to its latest version, please ensure that you have:

  • Updated the versions and releases in the scraper file
  • Ensured the license is up-to-date
  • Ensured the icons and the SOURCE file in public/icons/your_scraper_name/ are up-to-date if the documentation has a custom icon
  • Ensured self.links contains up-to-date urls if self.links is defined
  • Tested the changes locally to ensure:
    • The scraper still works without errors
    • The scraped documentation still looks consistent with the rest of DevDocs
    • The categorization of entries is still good

@morgabm morgabm requested a review from a team as a code owner July 11, 2024 15:46
Copy link
Contributor

@simon04 simon04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The scraper needs some adaptions. In particular, the extracted entries are completely different. All commands such as vkCmdBindVertexBuffers are missing from the entries now.

Screenshot 2024-07-17 at 06 13 38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants