Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README-CN.md #903

Merged
merged 3 commits into from
Jun 14, 2024
Merged

Update README-CN.md #903

merged 3 commits into from
Jun 14, 2024

Conversation

HashCookie
Copy link
Contributor

Checklist:

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the main branch of freeCodeCamp.

Closes #XXXXX

@Try2079
Copy link

Try2079 commented May 25, 2024

Hi, your Check README Suffixes / check-readme-suffixes (pull_request) passed, I want to know why.

我在刚刚更新了中文版的 README-CN.md，但提交 pull request 时，check 显示 Check README Suffixes / check-readme-suffixes (pull_request) 失败，想请教下你这是怎么回事，感谢！传送门

@HashCookie
Copy link
Contributor Author

Hi, your Check README Suffixes / check-readme-suffixes (pull_request) passed, I want to know why.

我在刚刚更新了中文版的 README-CN.md，但提交 pull request 时，check 显示 Check README Suffixes / check-readme-suffixes (pull_request) 失败，想请教下你这是怎么回事，感谢！传送门
看了一下貌似因为这里:

image

erictleung
erictleung approved these changes Jun 14, 2024
View reviewed changes
Copy link
Member

@erictleung erictleung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 Thanks for updating our translation! ✨

@erictleung erictleung merged commit 43f1fd4 into freeCodeCamp:main Jun 14, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erictleung erictleung erictleung approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HashCookie @Try2079 @erictleung