-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update readme #433
base: main
Are you sure you want to change the base?
chore: update readme #433
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, the instructions look solid to me. I'll try to follow them here. Thanks, @sidemt!
Co-authored-by: DanielRosa74 <[email protected]>
Co-authored-by: DanielRosa74 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Rafael D. Hernandez <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a final 5th step to make it clear that the contributor is only responsible for the first four steps. After that, the language leads will take care of everything else.
Co-authored-by: Rafael D. Hernandez <[email protected]>
Co-authored-by: Rafael D. Hernandez <[email protected]>
@RafaelDavisH Before merging this PR, do we want to inform other language leads about this new workflow and ask feedback from them? |
Yes, we ask them to run the GH actions a couple of times and provide some feedback before we officially announce it to the community of proofreaders. What you think @DanielRosa74 ? |
Sounds good, @RafaelDavisH! |
Checklist:
Update index.md
)