Mk/Uses/proccontrol.mk: add USES=proccontrol #300
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekhramtsov
force-pushed
the
procharden
branch
from
bd047e1
to
fbc6c30
Compare
|
chrome* IIRC I only build tested for PoC and didn't set elfctl on resulting binary, also tested like ~year ago and things could change. I would see/test later. |
ekhramtsov
force-pushed
the
procharden
branch
from
fbc6c30
to
0cc04cb
Compare
Ports (e.g. editors/neovim) can overwrite binary after post-build
in _STAGE_SEQ (bsd.port.mk) resulting in ELF flag loss.
Move elfctl to after post-stage so flags are set on final binary.
${INSTALL_PROGRAM} uses BINMODE (0555), so set to 0755 and do elfctl,
then restore old mode for poudriere build to succeed.
(XXX: find out how to declare and use variables inside loop to
remove hideous hack to store file mode)
Ports that need ELF flags for stage or build need proccontrol(1)
starting build or elfctl.mk needs to be changed for other stages.
PROCCONTROL_MODE allows to set process modes for port build stages, e.g. disable protmax and allow wxmap to build www/node when jail 0 is restricted.
ekhramtsov
force-pushed
the
procharden
branch
from
0cc04cb
to
a521521
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base has introduced proccontrol(1) in base@7402f93ef2ea to opt-out from execution modes (e.g. protmax after base@74a1b66cf41d.
Mk/Uses/proccontrol.mk allows to set process modes for build, e.g. disable protmax and allow wxmap to build e.g. Java when host is restricted (e.g. kern.elf64.allow_wx=0 vm.imply_prot_max=1).
UPD: This is heavily WIP until I get more time to separate out elfctl changes and chase elfctl change in tree. I'll likely publish to Phabricator and close this pull request once done.