ci: print warning when signing should happen in fork #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the CI pipeline fails when the image is built in a fork with a tag that matches a release that should be signed. This is due to the signing keys missing in the fork. This might break cases where a sign in a fork is desired, however we do not support this and probably also don't want this. If other people desire to use the script, they can exchange UPSTREAM_REPO_NAME with their own GitHub repo name. Inform the user if this happens with a warning message. Signed-off-by: David Bauer <[email protected]>
Even when the tag matches a release, we should never deploy in a fork. Signed-off-by: David Bauer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the CI pipeline fails when the image is built in a fork with a tag that matches a release that should be signed.
This is due to the signing keys missing in the fork.
This might break cases where a sign in a fork is desired, however we do not support this and probably also don't want this.
If other people desire to use the script, they can exchange UPSTREAM_REPO_NAME with their own GitHub repo name.
Inform the user if this happens with a warning message.