pr comments

frontegg · Sep 29, 2024 · 7a88b35 · 7a88b35
1 parent 8fc8756
commit 7a88b35
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 11 deletions.
diff --git a/common/unified-chart/templates/high-priority/hp-rollout.yaml b/common/unified-chart/templates/high-priority/hp-rollout.yaml
@@ -17,12 +17,12 @@ spec:
   strategy:
     {{- if .Values.argoRollouts.progressiveDelivery.enabled }}
     canary:
-    {{- with .Values.argoRollouts.progressiveDelivery }}
+      {{- with .Values.argoRollouts.progressiveDelivery }}
       stableMetadata:
       {{- toYaml .stableMetadata | nindent 8 }}
       canaryMetadata:
-      {{- toYaml .canaryMetadata| nindent 8 }}
-    {{- end }}
+      {{- toYaml .canaryMetadata | nindent 8 }}
+      {{- end }}
       canaryService: {{ include "hp.name" . }}-canary
       stableService: {{ include "hp.name" . }}-stable
       trafficRouting:

diff --git a/common/unified-chart/templates/high-priority/hp-service.yaml b/common/unified-chart/templates/high-priority/hp-service.yaml
@@ -12,7 +12,7 @@ metadata:
     {{- toYaml . | nindent 4 }}
     {{- end }}
 spec:
-  type: {{ $values.hp.service.type }}
+  type: {{ $values.hp.service.type | default "ClusterIP" }}
   ports:
     {{- range $values.hp.service.ports }}
     - port: {{ required ".Values.hp.service.ports[*].port number is required" .port }}

diff --git a/common/unified-chart/values.yaml b/common/unified-chart/values.yaml
@@ -15,7 +15,7 @@ argoRollouts:
     labels:
       role: active
   progressiveDelivery:
-    enabled: true
+    enabled: false
     stableMetadata:
       labels:
         role: stable
@@ -32,12 +32,6 @@ argoRollouts:
       - pause: {}
       - setWeight: 100
       - pause: { duration: 60s }
-      - analysis:
-          templates:
-            - templateName: black-box
-          args:
-            - name: service-name
-              value: progressive-delivery-test
 
 image:
   repository: