-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App Submission: Enclosed #1563
base: master
Are you sure you want to change the base?
App Submission: Enclosed #1563
Conversation
Will pick a different port, set relevant env vars to make it work and test on RPI |
@Zoobdude Very good app! Thanks for the tip! Works perfectly with Cloudflare. I took it to my community store: |
Thanks for submitting Enclosed @Zoobdude! This looks great. We've got our heads down on some other aspects of the codebase, but we have this on our radar and will get to it soon. FYI, the next port number of |
Co-authored-by: Nathan Fretz <[email protected]>
Thanks for the reply, didn't know the app_proxy could just change the port, that's pretty handy. I'll get some screenshots shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Zoobdude for the amazing app submission. I have only one very minor suggestion (see below). I have also tested the app and it is working perfectly :)
Co-authored-by: Josua Frank <[email protected]>
Just waiting to be back at my desk with my 4k monitor for the screenshots. Don't think my 2013 13" MacBook Air will cut it xD |
Hopefully those screenshots are alright! |
Yes, they are looking good :) Thank you |
Added app logo svg |
🎉 Linting finished with no errors or warnings 🎉Thank you for your submission! This is an automated linter that checks for common issues in pull requests to the Umbrel App Store. |
Wonderful, thanks again for this submission @Zoobdude! And thanks for reviewing @sharknoon. I have pushed a few changes to finalize the submission. We'll get the gallery assets created and then this is good to go live! Context for commit ea086b7: During testing, I ran into a permissions issue when creating a note:
This is because the uid/gid of the nonroot user wasn't being set correctly in the docker-compose.yml:
So the container was trying to write to a data directory owned by 1000:1000 (node) while operating as 100:101 Using the
|
I must admit, until using enclosed/umbrel I hadn't ever used alternative users in a docker container. Thanks for the explanation, I appreciate it! |
App Submission
App name
Enclosed
App logo
https://svgshare.com/s/1BQT
Gallery
1.jpg:
2.jpg:
3.jpg:
I have tested my app on:
[] umbrelOS on a Raspberry Pi
[] umbrelOS on an Umbrel Home
[] umbrelOS on Linux VM