Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix benchmarks #2498

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Fix benchmarks #2498

wants to merge 6 commits into from

Conversation

jimblandy
Copy link
Member

cargo bench doesn't run to completion at the moment.

This fixes the MSL backend, but there are further problems with the HLSL backend.

Introduce a new `Capabilities::BINDING_ARRAY` flag, which enables use
of the Naga `TypeInner::BindingArray` type.

Adjust tests that exercise binding arrays to pass this flag.
We haven't finished implementing WGSL's `atomicCompareExchangeWeak` on
all platforms (#1413). It's valuable to have some configuration of
validation that guarantees backends will succeed, and adding a
`Capabilities` bit that is included by default but can be turned off
accomplishes that.
@cwfitzgerald
Copy link
Member

Hello, thank you for your PR against Naga!

As part of gfx-rs/wgpu#4231, we have moved development of Naga into the wgpu repository in the Naga subfolder. We have transferred all issues, but we are unable to automatically transfer PRs.

As such, please recreate your PR against the wgpu repository. We apologize for the inconvenience this causes, but will make contributing to both projects more streamlined going forward.

We are leaving PRs open, but once they are transferred, please close the original Naga PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants