Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use xarray.Dataset/Array.sizes instead of .dims #84

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

timothyas
Copy link

There are a few places where the syntax xarray.Dataset.dims[varname] is used to get the length of e.g. varname. This produces the following warning of to-be-deprecated behavior

graphcast/graphcast/autoregressive.py:115: FutureWarning: The return type of `Dataset.dims` will be changed to return a set of dimension names in future, in order to be more consistent with `DataArray.dims`. To access a mapping from dimension names to lengths, please use `Dataset.sizes`.

(for reference this is with xarray version 2024.5.0)

This PR makes the replacement suggested by the warning. I think these are all the spots where this functionality of .dims is used, it's at least a good start.

Copy link

google-cla bot commented Jun 21, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant