Fix test case for dnc util_test.py for TF <=2.5 ,typo and link #218
Conversation
abhilash1910
changed the title
sonnet/src/nets/dnc/util_test.py
Outdated
| with self.assertRaisesIncompatibleShapesError( | ||
| tf.errors.InvalidArgumentError): | ||
| util.apply_linear((input_a, input_b), (lin_a, lin_b)) | ||
| if tf.__version__>="2.5.0": |
There was a problem hiding this comment.
in general we only maintain compatibility with the latest release of TensorFlow 2, so I would prefer not to merge the change in this file.
There was a problem hiding this comment.
Hi @tomhennigan , Thank you for the review. Will revert this to the original version.
| @@ -100,7 +100,7 @@ def deep_core(control_name, | |||
| num_layers: Number of layers. | |||
| skip_connections: Boolean that indicates whether to use skip connections. | |||
| See documenation for sonnet.DeepRnn in | |||
| //learning/deepmind/tensorflow/sonnet/python/modules/basic_rnn.py for more | |||
There was a problem hiding this comment.
Thank you for this, I think we can do even better if we use RST to x-link to the actual symbol. Then in our rendered docs (https://sonnet.dev) users can click through to DeepRNN. Concretely, I suggest changing this to:
See documentation for :class:`DeepRNN` for more information.
There was a problem hiding this comment.
Thank you for this review. Have made the change in the script.
|
Hi @tomhennigan , |
Changes addressed: