Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing expires_at field to github.Authorization #3251

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

t0rr3sp3dr0
Copy link

The response of client.Authorizations.Check(...) should contain the expires_at field.

https://docs.github.com/en/rest/apps/oauth-applications?apiVersion=2022-11-28#check-a-token

@gmlewis
Copy link
Collaborator

gmlewis commented Aug 28, 2024

Please run step 4 of CONTRIBUTING.md and push the results to this PR.
Thank you, @t0rr3sp3dr0 !

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.95%. Comparing base (2b8c7fa) to head (9b95df2).
Report is 129 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3251      +/-   ##
==========================================
- Coverage   97.72%   92.95%   -4.78%     
==========================================
  Files         153      171      +18     
  Lines       13390    11647    -1743     
==========================================
- Hits        13085    10826    -2259     
- Misses        215      727     +512     
- Partials       90       94       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmlewis
Copy link
Collaborator

gmlewis commented Oct 3, 2024

This PR will be closed and marked as abandoned if no response by next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants