Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Webhook for Repository ruleset #3305

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

unamdev0
Copy link

@unamdev0 unamdev0 commented Oct 4, 2024

Added Repository ruleset event
Fixes #3295

@unamdev0
Copy link
Author

unamdev0 commented Oct 4, 2024

@gmlewis please ignore the previous PR and review this. This PR contains just my code and hasn't been reabased with master branch.
updated RuleSet to Ruleset everywhere, also improved the comment describing the repository ruleset event

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to hold off reviewing this one until comments from the last PR are addressed.
Specifically,

Godocs should always use complete sentences with punctuation so that the auto-generated package documentation formats and reads nicely.

It looks like GitHub ate my other lengthy comment, unfortunately... but the gist of it was that every exported struct needs a Godoc-style comment to explain its purpose and usage for the auto-generated package documentation.

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.05%. Comparing base (2b8c7fa) to head (e63118c).
Report is 133 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3305      +/-   ##
==========================================
- Coverage   97.72%   93.05%   -4.67%     
==========================================
  Files         153      172      +19     
  Lines       13390    11772    -1618     
==========================================
- Hits        13085    10955    -2130     
- Misses        215      723     +508     
- Partials       90       94       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@unamdev0
Copy link
Author

unamdev0 commented Oct 4, 2024

I'm going to hold off reviewing this one until comments from the last PR are addressed.
Specifically,

Godocs should always use complete sentences with punctuation so that the auto-generated package documentation formats and reads nicely.

It looks like GitHub ate my other lengthy comment, unfortunately... but the gist of it was that every exported struct needs a Godoc-style comment to explain its purpose and usage for the auto-generated package documentation.

Got it, will add comments for every new struct added and will let you know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: repository ruleset event type not defined
2 participants