-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Webhook for Repository ruleset #3305
base: master
Are you sure you want to change the base?
Add Webhook for Repository ruleset #3305
Conversation
@gmlewis please ignore the previous PR and review this. This PR contains just my code and hasn't been reabased with master branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to hold off reviewing this one until comments from the last PR are addressed.
Specifically,
Godocs should always use complete sentences with punctuation so that the auto-generated package documentation formats and reads nicely.
It looks like GitHub ate my other lengthy comment, unfortunately... but the gist of it was that every exported struct needs a Godoc-style comment to explain its purpose and usage for the auto-generated package documentation.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3305 +/- ##
==========================================
- Coverage 97.72% 93.05% -4.67%
==========================================
Files 153 172 +19
Lines 13390 11772 -1618
==========================================
- Hits 13085 10955 -2130
- Misses 215 723 +508
- Partials 90 94 +4 ☔ View full report in Codecov by Sentry. |
Got it, will add comments for every new struct added and will let you know |
Added Repository ruleset event
Fixes #3295