Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow removing/unsetting repository custom property #3309

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

felixlut
Copy link
Contributor

@felixlut felixlut commented Oct 5, 2024

This change will allow a user to set null when calling the create/update repository custom property endpoint. As written in the docs, doing so will remove/unset the custom property. Currently doing so is not possible

Normally I think this would count as a breaking change, since this will modify the behavior when omitting the Value, but I believe this is a straight up bug, as omitting the Value should always result in an error. So there shouldn't be any usages that's relying on this behavior. Technically it's possible, but improbable.

@felixlut felixlut marked this pull request as ready for review October 5, 2024 21:23
@gmlewis gmlewis changed the title fix: allow removing/unsetting repository custom property fix: Allow removing/unsetting repository custom property Oct 6, 2024
@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Oct 6, 2024
Copy link

codecov bot commented Oct 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.05%. Comparing base (2b8c7fa) to head (e294fd7).
Report is 135 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3309      +/-   ##
==========================================
- Coverage   97.72%   93.05%   -4.67%     
==========================================
  Files         153      172      +19     
  Lines       13390    11772    -1618     
==========================================
- Hits        13085    10955    -2130     
- Misses        215      723     +508     
- Partials       90       94       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @felixlut !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsReview PR is awaiting a review before merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants