Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.1] Fixes version parsing for WARNING situations #443

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

Karm
Copy link
Collaborator

@Karm Karm commented Aug 19, 2024

@Karm Karm requested a review from jerboaa August 19, 2024 14:53
@Karm Karm self-assigned this Aug 19, 2024
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Aug 19, 2024
@jerboaa
Copy link
Collaborator

jerboaa commented Aug 19, 2024

Is this a git cherry-pick -x commit from master?

@Karm
Copy link
Collaborator Author

Karm commented Aug 19, 2024

@jerboaa

 git cherry-pick ff3824b

@jerboaa
Copy link
Collaborator

jerboaa commented Aug 19, 2024

@jerboaa

 git cherry-pick ff3824b

Could you please use -x option so that we know it's from a master commit by looking at the git log output. Thanks!

@Karm Karm force-pushed the 24.1-version-check-fails-on-warning branch from 4e2380b to ab9b96b Compare August 19, 2024 15:47
@Karm
Copy link
Collaborator Author

Karm commented Aug 19, 2024

@jerboaa

 git cherry-pick ff3824b

Could you please use -x option so that we know it's from a master commit by looking at the git log output. Thanks!

Done.

@Karm Karm merged commit 3817366 into graalvm:24.1 Aug 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants