Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rewards manager e2e config test #653

Merged
merged 1 commit into from
Jul 28, 2022
Merged

Conversation

tmigone
Copy link
Contributor

@tmigone tmigone commented Jul 28, 2022

PR #569 broke one of the rewards manager e2e config tests as it removed an initialization value from the initializer and instead is setting it with a function call.

Connected to: #654
Signed-off-by: Tomás Migone [email protected]

@tmigone tmigone requested a review from abarmat July 28, 2022 09:04
@codecov
Copy link

codecov bot commented Jul 28, 2022

Codecov Report

Merging #653 (4ae29a8) into dev (842a8da) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #653   +/-   ##
=======================================
  Coverage   90.35%   90.35%           
=======================================
  Files          35       35           
  Lines        1762     1762           
  Branches      296      296           
=======================================
  Hits         1592     1592           
  Misses        170      170           
Flag Coverage Δ
unittests 90.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 842a8da...4ae29a8. Read the comment docs.

Copy link
Contributor

@abarmat abarmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix!

@tmigone tmigone merged commit 35aa936 into dev Jul 28, 2022
@tmigone tmigone deleted the tmigone/fix-rewardsmanager-test branch July 28, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants