Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature |
graph init
Add support to download spkg files from spkg.io #1642base: main
Are you sure you want to change the base?
Feature |
graph init
Add support to download spkg files from spkg.io #1642Changes from 15 commits
1541c32
286a778
dbc2f94
70b799a
dd909e9
dba1fa3
4d63078
2e6448a
eb840d7
d995b1b
cddafba
e4fdb3c
74e2721
1d62121
908438c
461a3cd
239e528
8e13155
5c7ac2d
91e488c
7d24759
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would use
fetch
, we maintain an internal wrapper that also passes some headers that can let origin servers know where the traffic is coming from.graph-tooling/packages/cli/src/fetch.ts
Line 5 in 1f8d86f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have now resolved this to use the wrapped fetch
Check warning on line 1254 in packages/cli/src/commands/init.ts
GitHub Actions / Lint
Check warning on line 1317 in packages/cli/src/commands/init.ts
GitHub Actions / Lint