1822 infobox color typography update #1874
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Heading 1 in the style guide. This included changes to font family, size and line-height
…into 1822-infobox-color-typography-update
entrotech
requested changes
Oct 2, 2024
| marginTop: "22px" | ||
| } | ||
| }, | ||
| level0Message: { | ||
| marginTop: "20px", | ||
| maxWidth: "800px", | ||
| backgroundColor: "#FEF4F2", | ||
| backgroundColor: "#F9DFDA", |
There was a problem hiding this comment.
rather than hard-coding the color here, it should use the colors.tooltip from the theme.
| @@ -15,17 +15,17 @@ const useStyles = createUseStyles({ | |||
| textAlign: "center", | |||
|
|
|||
| "& h1": { | |||
There was a problem hiding this comment.
Instead of hard-coding the font-related styles, this should reference the theme's typography.heading1 style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #replace_this_text_with_the_issue_number
What changes did you make?
Issue-Specific User Account
If you registered a new, temporary TDM User Account for this issue, indicate the
username (i.e., email address) for the account.
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied