Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: update clarity representation #1646

Merged
merged 3 commits into from
Mar 7, 2024

Conversation

janniks
Copy link
Collaborator

@janniks janniks commented Mar 5, 2024

This PR was published to npm with the version 6.11.4-pr.e279ac3.0
e.g. npm install @stacks/[email protected] --save-exact

build
Update commitlint config to allow longer lines (e.g. when adding BREAKING CHANGE body to commit message.

refactor!
Introduce a new ClarityWireType to replace the existing ClarityType, which now is human-readable.

This is done in anticipation of stacksgov/sips#166

Next steps

In a future PR, I may update the .buffer, .value etc. to all follow a similar pattern (e.g. to all be .value)

Copy link

vercel bot commented Mar 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stacksjs-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 7, 2024 4:01pm

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 76.80412% with 135 lines in your changes are missing coverage. Please review.

Project coverage is 66.28%. Comparing base (922e037) to head (e279ac3).
Report is 12 commits behind head on next.

❗ Current head e279ac3 differs from pull request most recent head 6ddc393. Consider uploading reports for the commit 6ddc393 to get more accurate results

Files Patch % Lines
packages/api/src/api.ts 19.40% 54 Missing ⚠️
packages/cli/src/cli.ts 40.00% 24 Missing ⚠️
packages/transactions/src/fetch.ts 89.74% 12 Missing ⚠️
packages/network/src/network.ts 62.06% 8 Missing and 3 partials ⚠️
packages/transactions/src/builders.ts 84.78% 7 Missing ⚠️
packages/profile/src/profile.ts 25.00% 6 Missing ⚠️
packages/stacking/tests/apiMockingHelpers.ts 40.00% 6 Missing ⚠️
packages/auth/src/profile.ts 83.33% 4 Missing ⚠️
packages/common/src/utils.ts 69.23% 2 Missing and 2 partials ⚠️
packages/common/src/fetch.ts 40.00% 3 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1646      +/-   ##
==========================================
- Coverage   66.37%   66.28%   -0.09%     
==========================================
  Files         119      124       +5     
  Lines        8717     8676      -41     
  Branches     1920     1894      -26     
==========================================
- Hits         5786     5751      -35     
+ Misses       2806     2803       -3     
+ Partials      125      122       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@hugocaillard hugocaillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Base automatically changed from feat/next-update-cli to next March 7, 2024 15:58
BREAKING CHANGE:
The `ClarityType` was changed to a readable string, from the previous Number type. This makes it easier to read and construct types when debugging.
@janniks janniks force-pushed the refactor/next-update-clarity-helpers branch from e279ac3 to 6ddc393 Compare March 7, 2024 15:59
@janniks janniks changed the title refactor!: update clarity helpers refactor!: update clarity representation Mar 7, 2024
@janniks janniks merged commit cd4568f into next Mar 7, 2024
7 of 8 checks passed
@janniks janniks deleted the refactor/next-update-clarity-helpers branch March 7, 2024 16:00
@janniks janniks restored the refactor/next-update-clarity-helpers branch March 12, 2024 01:36
@janniks janniks deleted the refactor/next-update-clarity-helpers branch March 12, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants