feat: create @stacks/rpc-client package #1737
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
zone117x
commented
Aug 15, 2024
Comment on lines
-111
to
-113
| const headers = new Headers(context.init.headers); | ||
| const headers = | ||
| context.init.headers instanceof Headers | ||
| ? context.init.headers | ||
| : (context.init.headers = new Headers(context.init.headers)); | ||
| headers.set(httpHeader, apiKey); | ||
| context.init.headers = headers; |
There was a problem hiding this comment.
This fixes a bug where in some instances the headers property is a read-only getter and cannot be re-assigned.
|
This is going into its own repo and will be closed when that's ready. /cc @janniks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RPC schema is being removed from the
stacks-blockchain-apicodebase. This means the@stacks/blockchain-api-clientlibrary will no longer include auto-generated code for those endpoints. See more details over at that repo: PR, client migration notes.This PR creates a new library
@stacks/rpc-clientwhich generates a client library using the canonical RPC schema athttps://github.com/stacks-network/stacks-core/blob/master/docs/rpc/openapi.yaml
The library http request types are generated using
openapi-typescript, and depends onopenapi-fetch.Some glue code is included to easily use the existing
StacksNetworkobjects and middleware, and also to export some common types.