feat(telemetry): adds reads and writes #25409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praveen-influx
force-pushed
the
praveen/telem-writes-report
branch
11 times, most recently
from
818eed9
to
ad415c4
Compare
hiltontj
approved these changes
Oct 1, 2024
influxdb3_telemetry/Cargo.toml
Outdated
Comment on lines
20
to
21
| tonic.workspace = true | ||
| tower.workspace = true |
There was a problem hiding this comment.
Are these used since moving away from the middleware/interceptor approach?
pauldix
requested changes
Oct 1, 2024
influxdb3_server/src/http.rs
Outdated
| let num_lines = result.line_count; | ||
| let payload_size = body.len(); | ||
| let telem_store = Arc::clone(&self.common_state.telemetry_store); | ||
| tokio::spawn(async move { |
There was a problem hiding this comment.
I don't think we want to spawn on every write call. We should be able to just call add_write_metrics on the store without this.
| @@ -146,6 +151,13 @@ impl QueryExecutor for QueryExecutorImpl { | |||
| let token = token.permit(); | |||
|
|
|||
| debug!("execute stream of query results"); | |||
|
|
|||
| let telem_clone = Arc::clone(&self.telemetry_store); | |||
| tokio::spawn(async move { | |||
There was a problem hiding this comment.
Same as before, we don't want to spawn on every query.
praveen-influx
force-pushed
the
praveen/telem-writes-report
branch
from
ad415c4
to
0930477
Compare
- instrumented code to get read and write measurement - introduced EventsBucket for collection of reads/writes - sampler now samples every minute for all metrics (including reads/writes) - other tidy ups closes: #25372
praveen-influx
force-pushed
the
praveen/telem-writes-report
branch
from
0930477
to
62093bd
Compare
pauldix
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #25372