Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement PBR Maps Node #6720

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Implement PBR Maps Node #6720

wants to merge 1 commit into from
+691 −0

Conversation

blessedcoolant
Copy link
Collaborator

@blessedcoolant blessedcoolant commented Aug 5, 2024 •
edited
Loading

A node to generate normal, roughness and displacement maps from a single image. Based on: https://github.com/joeyballentine/Material-Map-Generator

opera_5hPWwqnPaj

@github-actions github-actions bot added python PRs that change python files invocations PRs that change invocations backend PRs that change backend files labels Aug 5, 2024
lstein
lstein approved these changes Aug 10, 2024
View reviewed changes
Copy link
Collaborator

@lstein lstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Happy to see that load_remote_model() is working as intended.

@blessedcoolant @hipsterusername
initial: Implement PBR Maps node
1388f85 
A node to generate normal, roughness and displacement maps from a single image. Based on: https://github.com/joeyballentine/Material-Map-Generator
@hipsterusername
Copy link
Member

@psychedelicious @RyanJDick @brandonrising - I imagine we want to handle these models differently, thinking about new user UX (and hosting these)?

@blessedcoolant
Copy link
Collaborator Author

I think it's better we host them ourselves. The Github downloads can take ridiculously long sometimes for no apparent reason. The UI use case would be currently right click on an image and say "Generate PBR Maps" from it. Ideally we want to do a proper 3D viewer for previewing the model but that's an entirely different feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lstein lstein lstein approved these changes

@brandonrising brandonrising Awaiting requested review from brandonrising brandonrising is a code owner

@RyanJDick RyanJDick Awaiting requested review from RyanJDick RyanJDick is a code owner

@hipsterusername hipsterusername Awaiting requested review from hipsterusername hipsterusername is a code owner

@psychedelicious psychedelicious Awaiting requested review from psychedelicious psychedelicious is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
backend PRs that change backend files invocations PRs that change invocations python PRs that change python files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blessedcoolant @hipsterusername @lstein