fix: goreleaser v2 compat, trigger release-binaries with workflow_run #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvagg
requested review from
willscott,
masih and
hannahhoward
as code owners
masih
approved these changes
Sep 25, 2024
|
|
||
| workflow_dispatch: | ||
| workflow_run: | ||
| workflows: [Releaser] |
There was a problem hiding this comment.
Relases created by GitHub actions will not create other workflows, unless they use a GitHub Token other than the built-in default.
An alternative solution is to delete and recreate the release manually.
I pointed this out to IPDX team a while back and I believe there has been fixes rolled out to the unified CI? It's worth checking with them.
There was a problem hiding this comment.
🤷 this seems to work in the lassie repo where we have essentially the same setup and no custom token configured
There was a problem hiding this comment.
https://github.com/filecoin-project/lassie/actions/runs/9691067118
Triggered via workflow run 3 months ago
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #536
(a small amount of 🤞 going on here, we'll see, this works for lassie)