Skip to content

Commit

Permalink
Feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
KyleAure committed Sep 17, 2024
1 parent f193be7 commit 2fd7300
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 12 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,4 +52,4 @@ jobs:
- name: Analyze starters
# Note: the starter is always 1 version ahead of what is in maven central
# therefore, when we analyze the starters we need to force a prior version
run: mvn dependency:analyze -Djakarta.concurrent.version=3.1.1 --file tck-dist/src/main/starter/pom.xml
run: mvn dependency:analyze -Djakarta.concurrent.groupid=jakarta.enterprise.concurrent -Djakarta.concurrent.version=3.1.1 --file tck-dist/src/main/starter/pom.xml
7 changes: 0 additions & 7 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,6 @@
<version>3.2.0-SNAPSHOT</version>
<packaging>pom</packaging>

<distributionManagement>
<relocation>
<groupId>jakarta.enterprise.concurrent</groupId>
<artifactId>jakarta.enterprise.concurrent.parent</artifactId>
</relocation>
</distributionManagement>

<name>Jakarta Concurrency</name>
<description>Jakarta Concurrency Parent</description>
<url>https://github.com/jakartaee/concurrency</url>
Expand Down
9 changes: 5 additions & 4 deletions tck-dist/src/main/starter/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
<maven.compiler.target>21</maven.compiler.target>

<!-- Dependency and Plugin Versions -->
<jakarta.concurrent.groupid>jakarta.concurrent</jakarta.concurrent.groupid>
<jakarta.concurrent.version>3.2.0</jakarta.concurrent.version>
<jakarta.servlet.version>6.1.0</jakarta.servlet.version>

Expand Down Expand Up @@ -112,14 +113,14 @@
<dependencies>
<!-- The TCK -->
<dependency>
<groupId>jakarta.concurrent</groupId>
<artifactId>jakarta.concurrent-tck</artifactId>
<groupId>${jakarta.concurrent.groupid}</groupId>
<artifactId>${jakarta.concurrent.groupid}-tck</artifactId>
<version>${jakarta.concurrent.version}</version>
</dependency>
<!-- The API -->
<dependency>
<groupId>jakarta.concurrent</groupId>
<artifactId>jakarta.concurrent-api</artifactId>
<groupId>${jakarta.concurrent.groupid}</groupId>
<artifactId>${jakarta.concurrent.groupid}-api</artifactId>
<version>${jakarta.concurrent.version}</version>
</dependency>
<!-- Arquillian Implementation for JUnit5 -->
Expand Down

0 comments on commit 2fd7300

Please sign in to comment.