Initial jms refactor #1496
Merged
Initial jms refactor #1496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to jakartaee#1495 Signed-off-by: Scott M Stark <[email protected]>
pzygielo
reviewed
Aug 24, 2024
| closedQueueReceiver_appclient_vehicle_client.addAsManifestResource(resURL, "application-client.xml"); | ||
| } | ||
| // The sun-application-client.xml file need to be added or should this be in in the vendor Arquillian extension? | ||
| resURL = ClosedQueueReceiverTests.class.getResource("//com/sun/ts/tests/common/vehicle/appclient/appclient_vehicle_client.jar.sun-application-client.xml"); |
There was a problem hiding this comment.
We decided to add the sun descriptors as a flag that a test archive might need a vendor descriptor.
There was a problem hiding this comment.
Unclear why this one (and few more in other places) needs two slashes at start.
Signed-off-by: Scott M Stark <[email protected]>
Signed-off-by: Scott M Stark <[email protected]>
Signed-off-by: Scott M Stark <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1495
Related Issue(s)
Initial port of the jms module to arquillian/junit5