Skip to content

Commit

Permalink
Bug 1919963 [wpt PR 48228] - Remove ::select-fallback-button, a=testonly
Browse files Browse the repository at this point in the history
Automatic update from web-platform-tests
Remove ::select-fallback-button

This patch removes customizable <select>'s fallback <button> element in
the UA shadowroot by replacing it with the same "InnerElement" <div>
which is used for appearance:auto.

Several supporting changes were made in order to implement this:
- Also remove ::select-fallback-button-text
- Add -internal-appearance-auto-base-select() support for the following
  properties:
  - min-block-size
  - min-inline-size
  - padding-block-start
  - padding-block-end
  - padding-inline-start
  - padding-inline-end
  - content in select::after
- Make <select> focusable again when there is no child <button> element
- Remove dependency on popover triggering code in HTMLFormControlElement
  now that we aren't always opening the popover with a <button>

This is in response to feedback here:
w3c/csswg-drafts#10717

This also addresses additional feedback I received privately that author
styles applied to the select element itself weren't applying to the
in-page portion of the element.

Change-Id: I0a833b370babe9a8ab937822a3578d839510a8fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5786670
Reviewed-by: David Baron <[email protected]>
Commit-Queue: Joey Arhar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1356701}

--

wpt-commits: 580c17ae11cbcffe0ee3cc44f521dddf77120f0f
wpt-pr: 48228
  • Loading branch information
josepharhar authored and moz-wptsync-bot committed Sep 25, 2024
1 parent 5b47385 commit fdc1fe7
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 32 deletions.

This file was deleted.

This file was deleted.

0 comments on commit fdc1fe7

Please sign in to comment.