This repository has been archived by the owner on Oct 7, 2020. It is now read-only.
Issue Fixed - Hidden Banner Not Shown #126
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I fixed an issue where the banner was not able to be shown again to the user after it is hidden.
For example, if the user is typing, a developer can call the function
```
$(window).data('smartbanner').hide();
```
to hide the banner so that the user has more room to type. Once the user is finished typing, the developer can call the function
```
$(window).data('smartbanner').show();
```
to show the banner again. However, there was a bug in the show() function where the banner is not actually displayed to the user a second time. I have fixed the bug via calling the jQuery show() function after the banner animation.
Thanks,
Shahzore
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed an issue where the banner was not able to be shown again to the user after it is hidden.
For example, if the user is typing, a developer can call the function
to hide the banner so that the user has more room to type. Once the user is finished typing, the developer can call the function
to show the banner again. However, there was a bug in the show() function where the banner is not actually displayed to the user a second time. I have fixed the bug via calling the jQuery show() function after the banner animation.
Thanks,
Shahzore