code changes to adapt aws-sdk v3 #130
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice! just what I'm also looking for! 🙏🏼 |
|
I think we need to update package.json as well. Would be great if aws-sdk is also converted from devDep to dependency |
|
Is there any update on if/when this might get merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I wanted to use the wrapper for my code and realized the support for v3 was not there yet. I needed to upgrade our code to aws-sdk v3 and hence would need this wrapper to also use aws-sdk v3 for compatibility. I have made the changes for the same. Please take a look and let me know if anything.
Thanks,
Karan