Skip to content

Commit

Permalink
Fix warning ConstraintDeclarationException
Browse files Browse the repository at this point in the history
A method overriding another method must not redefine the parameter constraint configuration, but method InMemoryStatisticsRepository#get(StatisticsCriteria) redefines the configuration of StatisticsRepository#get(StatisticsCriteria)
  • Loading branch information
murdos committed Feb 4, 2024
1 parent 33127be commit 0fa6e75
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package tech.jhipster.lite.statistic.infrastructure.secondary;

import jakarta.validation.constraints.NotNull;
import java.util.Collection;
import java.util.Collections;
import java.util.concurrent.ConcurrentHashMap;
Expand All @@ -25,7 +24,9 @@ public void save(AppliedModule moduleApplied) {
}

@Override
public Statistics get(@NotNull StatisticsCriteria criteria) {
public Statistics get(StatisticsCriteria criteria) {
Assert.notNull("criteria", criteria);

long appliedModulesCount = appliedModules.size();
if (criteria.isAnyCriteriaApplied()) {
appliedModulesCount =
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,9 @@ public void save(AppliedModule moduleApplied) {
}

@Override
public Statistics get(@NotNull StatisticsCriteria criteria) {
public Statistics get(StatisticsCriteria criteria) {
Assert.notNull("criteria", criteria);

if (criteria.isAnyCriteriaApplied()) {
Query query = generateQuery(criteria);
return new Statistics(mongoTemplate.count(query, AppliedModuleDocument.class));
Expand Down

0 comments on commit 0fa6e75

Please sign in to comment.