refactor: restrict method visibility and improve method name.

jhipster · May 31, 2024 · ad82b67 · ad82b67
1 parent 83b906e
commit ad82b67
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/src/main/java/tech/jhipster/lite/module/domain/javadependency/JavaDependency.java b/src/main/java/tech/jhipster/lite/module/domain/javadependency/JavaDependency.java
@@ -69,7 +69,7 @@ public static Function<VersionSlug, Optional<JavaDependencyVersion>> toVersion(
     return toVersion(currentVersions, projectDependencies, List.of());
   }
 
-  public static Function<VersionSlug, Optional<JavaDependencyVersion>> toVersion(
+  private static Function<VersionSlug, Optional<JavaDependencyVersion>> toVersion(
     JavaDependenciesVersions currentVersions,
     ProjectJavaDependencies projectDependencies,
     Collection<JavaBuildCommand> dependencyCommands
@@ -89,14 +89,18 @@ private static Function<JavaDependencyVersion, Optional<JavaDependencyVersion>>
     Collection<JavaBuildCommand> dependencyCommands
   ) {
     return version -> {
-      if (version.equals(currentVersion) && dependencyCommands.stream().noneMatch(AddDirectJavaDependency.class::isInstance)) {
+      if (version.equals(currentVersion) && hasNoAddDirectJavaDependency(dependencyCommands)) {
         return Optional.empty();
       }
 
       return Optional.of(currentVersion);
     };
   }
 
+  private static boolean hasNoAddDirectJavaDependency(Collection<JavaBuildCommand> dependencyCommands) {
+    return dependencyCommands.stream().noneMatch(AddDirectJavaDependency.class::isInstance);
+  }
+
   private Function<JavaDependencyVersion, JavaBuildCommand> toSetVersionCommand() {
     return SetVersion::new;
   }