I18n modules in tests ci #11015
Merged
I18n modules in tests ci #11015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murdos
added
area: enhancement 🔧
generator: CI
client: react
and removed
area: triage
labels
murdos
previously approved these changes
Sep 30, 2024
fabienpuissant
force-pushed
the
i18n-modules-in-tests-ci
branch
from
e5359ce
to
2f7614a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sounds good to include i18n modules in the test-ci
Doing that, I saw that test cases were missing and also fixed a bug on it.
Will be better for react once refactor will be done. ATM just ignoring i18n.ts in coverage